Skip to content

Commit 8ec918f

Browse files
authored
Merge pull request #1771 from magda-io/release/0.0.49-RC3
changes during deployment attempts
2 parents 9c4bf69 + 7781da8 commit 8ec918f

File tree

5 files changed

+11
-4
lines changed

5 files changed

+11
-4
lines changed

CHANGES.md

+4
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@
2424
- Better support for SPSS files in the format minion
2525
- Made files marked with a ".extension" format resolve to "extension" correctly in the format minion.
2626
- Fixed an redirection issue when handling 404 status from registry API
27+
- Re-added admin api to released docker images
28+
- Made gateway nominate its container port to fix it working with a password and also the GCE ingress
29+
- Stopped the helm chart from assuming that the `postgres` user password and the `proxyuser` password are the same in GKE deploys
30+
- Fixed the storage account credentials being created incorrectly through the secrets tool
2731

2832
## 0.0.48
2933

deploy/helm/magda/charts/gateway/templates/deployment.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ spec:
1515
- name: gateway
1616
image: {{ template "dockerimage" . }}
1717
imagePullPolicy: {{ .Values.image.pullPolicy | default .Values.global.image.pullPolicy }}
18+
ports:
19+
- containerPort: {{ .Values.service.internalPort }}
1820
command: [
1921
"node",
2022
"/usr/src/app/component/dist/index.js",

deploy/helm/magda/templates/_helpers.tpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
4444
valueFrom:
4545
secretKeyRef:
4646
name: cloudsql-db-credentials
47-
key: password
47+
key: postgres-password
4848
{{- else if not .Values.global.noDbAuth }}
4949
- name: PGPASSWORD
5050
valueFrom:

magda-admin-api/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
"dev": "run-typescript-in-nodemon src/index.ts",
1010
"docker-build-local": "create-docker-context-for-node-component --build --push --tag auto --local",
1111
"docker-build-prod": "create-docker-context-for-node-component --build --push --tag auto",
12-
"test": "mocha --compilers ts:ts-node/register,tsx:ts-node/register --require tsconfig-paths/register \"src/test/**/*.spec.ts\""
12+
"test": "mocha --compilers ts:ts-node/register,tsx:ts-node/register --require tsconfig-paths/register \"src/test/**/*.spec.ts\"",
13+
"retag-and-push": "retag-and-push"
1314
},
1415
"dependencies": {
1516
"@magda/typescript-common": "^0.0.49-RC2",

scripts/create-secrets/k8sExecution.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ function doK8sExecution(config, shouldNotAsk = false) {
9696
namespace,
9797
"cloudsql-instance-credentials",
9898
"credentials.json",
99-
configData["cloudsql-instance-credentials"]
99+
configData["cloudsql-instance-credentials"]["data"]
100100
);
101101
}
102102

@@ -106,7 +106,7 @@ function doK8sExecution(config, shouldNotAsk = false) {
106106
namespace,
107107
"storage-account-credentials",
108108
"db-service-account-private-key.json",
109-
configData["storage-account-credentials"]
109+
configData["storage-account-credentials"]["data"]
110110
);
111111
}
112112

0 commit comments

Comments
 (0)