Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageBuilder "Products" memory exhaustion in the backend #39564

Open
1 of 5 tasks
ioweb-gr opened this issue Jan 26, 2025 · 7 comments
Open
1 of 5 tasks

PageBuilder "Products" memory exhaustion in the backend #39564

ioweb-gr opened this issue Jan 26, 2025 · 7 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p2 Indicates original Magento version for the Issue report.

Comments

@ioweb-gr
Copy link
Contributor

Preconditions and environment

  • 2.4.7-p2
  • A large catalog with over 4m products of which the majority is configurable products

Steps to reproduce

  1. Navigate to Content -> Pages
  2. Add a new page
  3. Add a new element of type "Products"
  4. Try to work with the conditions
  5. Watch the system crawl to a halt
firefox_ZwX539ahmb.mp4

Internally the system will invoke function \Magento\PageBuilder\Model\Catalog\ProductTotals::getProductTotals which ends up in memory exhaustion

 PHP Fatal error:  Allowed memory size of 805306368 bytes exhausted (tried to allocate 38080004 bytes) in vendor/magento/zend-db/library/Zend/Db/Adapter/Abstract.php on line 875

I've tried increasing up to 12GB and the error is the same.

Expected result

The counts are calculated properly and the system doesn't crash

Actual result

Memory is exhausted

Additional information

After creating an around plugin on the mentioned function this is how fast it loads

<?php
/**
 * Copyright (c) 2025. IOWEB TECHNOLOGIES
 */

namespace Ioweb\MagentoPageBuilderBugFix\Plugin;


use Magento\PageBuilder\Model\Catalog\ProductTotals;

class DisableGetProductTotalsDueToSlowness
{
    /**
     * @param ProductTotals $subject
     * @param callable $proceed
     * @param string $conditions
     * @return array
     */
    public function aroundGetProductTotals(ProductTotals $subject, callable $proceed, string $conditions): array
    {
        return [
            'total' => 0,
            'disabled' => 0,
            'notVisible' => 0
        ];
    }
}
firefox_zS2mOz03PM.mp4

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jan 26, 2025

Hi @ioweb-gr. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Jan 27, 2025

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi @ioweb-gr ,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshot.

Steps to reproduce

  1. Navigate to Content -> Pages
  2. Add a new page
  3. Add a new element of type "Products"
  4. Try to work with the conditions

Image

Image

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Delta engcom-Delta added Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. and removed Issue: ready for confirmation labels Jan 27, 2025
@ioweb-gr
Copy link
Contributor Author

Dear @engcom-Delta

Please try the following

Make sure you have at least a few million products with at least 30% configurable products

Secondly instead of choosing the SKU button click on the one that says "Conditions"

In the conditions add something generic like

"Product is in category Default Category"

With the sku filter the issue doesn't occur but it occurs with the Conditions filter

@ioweb-gr
Copy link
Contributor Author

You can try the Category filter as well instead of the SKU filter. That one times out for us as well

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Jan 28, 2025
@engcom-Hotel engcom-Hotel moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Jan 28, 2025
@ioweb-gr ioweb-gr changed the title PageBuilder "Products" memory exhaustion PageBuilder "Products" memory exhaustion in the backend Jan 28, 2025
@engcom-Delta
Copy link
Contributor

Hi @ioweb-gr ,

Thanks for your reporting and collaboration.
We have tried to reproduce the issue again in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshot.

Steps to reproduce

  1. Prepare an instance with million products.
  2. Navigate to Content -> Pages
  3. Add a new page
  4. Add a new element of type "Products"
  5. Try to work with the conditions
  6. Observe user is able to apply the conditions and save the page.

Image

Image

Can you please reverify in latest 2.4 develop and confirm if you are still facing the issue.

Thanks.

@ioweb-gr
Copy link
Contributor Author

ioweb-gr commented Jan 30, 2025

I've tried to install 2.4-develop locally but facing this error during composer install

  - Downloading magento/oauth (1.0.0-beta106)
 11/11 [============================] 100%
In CurlDownloader.php line 641:

  The "https://repo.magento.com/archives/magento/ringphp/magento-ringphp-1.0.0.0-beta106.zip" file could not be downloaded (HTTP/2 404 ):
  "This might just be a temporary issue, please try again in a moment. If the problem persists, please contact your Adobe Account Manager to confirm that your license entitlement has not expired."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p2 Indicates original Magento version for the Issue report.
Projects
Development

No branches or pull requests

3 participants