Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog price rules with SKU using "not one of" and configurable products #39567

Open
5 tasks
hsmusz opened this issue Jan 27, 2025 · 6 comments
Open
5 tasks
Labels
Area: Catalog Component: CatalogRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@hsmusz
Copy link

hsmusz commented Jan 27, 2025

Preconditions and environment

Magento version: 2.4.4

Scenario: we have a Configurable product with SKU: 0001-00-group and multiple volume variants of that product as simple products with SKU like 0001-10M, 0001-25M. We would like to add a catalog price rule for every product except for some of the SKUs like 0001-25M (we want to exclude only single variants manually)

Problem: when creating a catalog price rule, when we use SKU with "not one of", and we add 0001-25M,0002-25M, the products are still affected by the price change, because the parent product (0001-00-group configurable) is matched with that rule, and expanded to every product it contains (due to code in aroundGetMatchingProductIds in ConfigurableProductHandler from Magento\CatalogRuleConfigurable\Plugin\CatalogRule\Model\Rule)

There is a code in that class that should allow matching products by products filters and exclude them from matched subProducts, but when we filter only by SKU, those are not excluded.

Steps to reproduce

  1. create a configurable product with multiple variants as simple products
  2. enable SKU to be used in price rules
  3. create catalog price rule, and use SKU as filter with a "not one of" option, and provide simple product SKU

Expected result

All products EXCEPT the provided SKU should be affected by the catalog price rule

Actual result

All products including the provided SKU are affected by the price rule, because the given SKU is a sub-product of a configurable product.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jan 27, 2025

Hi @hsmusz. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Jan 27, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@hsmusz
Copy link
Author

hsmusz commented Jan 27, 2025

I've recreated that behavior on clean 2.4.7-p3 instance

Image
Image
Image

The product excluded in the rule is still affected by the price change
Image

@engcom-Bravo
Copy link
Contributor

Hi @hsmusz,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue.Kindly refer the screenshots.

Image

Image Image

The product excluded in the rule is still affected by the price change

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Component: CatalogRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Catalog labels Jan 28, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13827 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Jan 28, 2025

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: CatalogRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

5 participants