Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] [Feature request] Add some functions in Magento\Checkout\Model\Session #39573

Open
4 of 5 tasks
m2-assistant bot opened this issue Jan 28, 2025 · 2 comments · May be fixed by #39571
Open
4 of 5 tasks

[Issue] [Feature request] Add some functions in Magento\Checkout\Model\Session #39573

m2-assistant bot opened this issue Jan 28, 2025 · 2 comments · May be fixed by #39571
Assignees
@engcom-Bravo
Labels
feature request Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2025

This issue is automatically created based on existing pull request: #39571: [Feature request] Add some functions in Magento\Checkout\Model\Session

Description (*)

This PR add some functions in Magento\Checkout\Model\Session with phpdoc (method tag) :

  • getLastOrderId
  • setLastOrderId
  • getLastRealOrderId
  • setLastRealOrderId
  • getLastOrderStatus
  • setLastOrderStatus
  • getLastQuoteId
  • setLastQuoteId
  • getLastSuccessQuoteId
  • setLastSuccessQuoteId

Adding these methods allows better support for phpstan. Today, with PHPSTAN is very complicated to setup the project with level 5 or higher :(

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Setup PHPSTAN with level 5 or higher and run check.

Questions or comments

The quality of Magento code needs to be improved so that it is easier to use the code quality tools (phpstan, rector, ...) ❤️

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Jan 28, 2025 that will close this issue
Open
6 tasks
@engcom-Bravo engcom-Bravo self-assigned this Jan 28, 2025
@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Jan 28, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Jan 28, 2025
@engcom-Bravo
Copy link
Contributor

Hi @dimitriBouteille,

Thanks for your reporting and collaboration.

We are marking this as Feature Request as an improvement to proceed further.

Thanks.

@engcom-Bravo engcom-Bravo moved this to Ready for Grooming in Feature Requests Backlog Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-Bravo engcom-Bravo

Labels
feature request Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Feature Requests Backlog
Status: Ready for Grooming
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature request] Add some functions in Magento\Checkout\Model\Session dimitriBouteille/magento2
1 participant
@engcom-Bravo