Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: hook after response given + unlimited number of hooks (array) #53

Open
JannisBush opened this issue Apr 9, 2019 · 4 comments

Comments

@JannisBush
Copy link
Contributor

No description provided.

@michael-franke
Copy link
Member

The hook system seems unable to realize basic affordances. An example is in SimonTask -> branch example_hook_problems.

Desired behavior:

  • pause
  • fixation cross
  • 3 things happen simultaneously:
    • RT measurement starts
    • response enabled
    • stimulus shown
       
      I don't see how this is possible to be realized at present. We may wish to consider an event system based on absolute time. E.g., user specifies view-manipulating functions (same as used for customization, if possible) that kick in at different absolute times (as specified in view-instantiation).

@JannisBush
Copy link
Contributor Author

This behavior works perfectly fine and was (almost) already there.

The problem that the stimulus hides after a short time was introduced here: hide of stimulus added, this also makes it only possible to answer after the stimulus hides (see here for explanation of the hook/trial life cycle)

The problem that the response was enabled to early was introduced here:
response enabled to early

The RT measurement was actually incorrect, because only the pause was subtracted and not the fixation time and the stim duration. I now changed it, to only start measuring the RT after the response is enabled, this means we don't have to subtract anything.

magpie-ea/magpie-simon-task@3f01f3d

Here, I pushed the fixed hooks version.

@michael-franke
Copy link
Member

michael-franke commented Apr 12, 2019 via email

@JannisBush
Copy link
Contributor Author

Okay, then we can't use the stimulus hide step of the trial life cycle. But we can just do the same thing it does in the after_response_enabled hook.
I pushed the changes (also added the reminder) to the hook branch.

The problem (related to this #53 issue) is, that we have no after response given hook, therefore I had to clear the timeouts in the custom view/handleResponse.

Also, I realized we have no before_pause hook, which could be useful and be realized in connection to the unlimited number of hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants