Fix playerbot crash when rolling for loot (#112)

i-am-fyre · web-flow · commit 397b623e66d2 · 2025-03-08T19:36:36.000Z
diff --git a/src/modules/Bots/playerbot/strategy/actions/LootRollAction.cpp b/src/modules/Bots/playerbot/strategy/actions/LootRollAction.cpp
@@ -47,11 +47,11 @@ bool LootRollAction::Execute(Event event)
         }
     }
 #else
-    for (vector<Roll*>::iterator i = group->GetRolls().begin(); i != group->GetRolls().end(); ++i)
+    for (auto& roll : group->GetRolls())
     {
-        if ((*i)->isValid() && (*i)->lootedTargetGUID == guid && (*i)->itemSlot == slot)
+        if (roll->isValid() && roll->lootedTargetGUID == guid && roll->itemSlot == slot)
         {
-            uint32 itemId = (*i)->itemid;
+            uint32 itemId = roll->itemid;
             ItemPrototype const *proto = sItemStorage.LookupEntry<ItemPrototype>(itemId);
             if (!proto)
             {

Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,11 @@ bool LootRollAction::Execute(Event event)`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`	`#else`
`50`		`- for (vector<Roll*>::iterator i = group->GetRolls().begin(); i != group->GetRolls().end(); ++i)`
	`50`	`+ for (auto& roll : group->GetRolls())`
`51`	`51`	`{`
`52`		`- if ((i)->isValid() && (i)->lootedTargetGUID == guid && (*i)->itemSlot == slot)`
	`52`	`+ if (roll->isValid() && roll->lootedTargetGUID == guid && roll->itemSlot == slot)`
`53`	`53`	`{`
`54`		`- uint32 itemId = (*i)->itemid;`
	`54`	`+ uint32 itemId = roll->itemid;`
`55`	`55`	`ItemPrototype const *proto = sItemStorage.LookupEntry<ItemPrototype>(itemId);`
`56`	`56`	`if (!proto)`
`57`	`57`	`{`