Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot title and plot window title are not updated when renaming the workspace #741

Open
SilkeSchomann opened this issue May 16, 2022 · 2 comments
Assignees

Comments

@SilkeSchomann
Copy link
Collaborator

Describe the bug
Renaming the workspace does not have an impact on the plot title and plot window title of a slice plot.

Expected behavior
The plot window title of a slice plot should always get updated when the underlying workspace is renamed. The plot title it should get updated when the user has not changed the title, that is when the plot title is still the same as the previous workspace name.

Additional context
Mantid shows the correct behaviour for this.

@MialLewis MialLewis self-assigned this May 23, 2022
@MialLewis
Copy link
Contributor

MialLewis commented May 24, 2022

Having spent a bit of time looking at this, I think this falls more under the feature category, and therefore should be developed after the feature freeze.

In Mantid renaming is handled via the ADS observers, which trigger renameHandle in the figuremanager, causing the titles etc, of related figures to be renamed.

As far as I can see, there doesn't seem to be any equivalent link (via observers or otherwise) between workspaces and figures in mslice. Hence a feature to create this link needs to be added. This could possibly be incorporated into the globalfiguremanager/observabledictionary

@SilkeSchomann
Copy link
Collaborator Author

Agreed. Will replace labels accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants