Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Messaging logic into default extensions. #2269

Closed
JThramer opened this issue Nov 12, 2019 · 1 comment
Closed

Move Messaging logic into default extensions. #2269

JThramer opened this issue Nov 12, 2019 · 1 comment
Labels
backwards incompatible changes that break backwards compatibility of public API feature New feature request. topic: architecture

Comments

@JThramer
Copy link
Contributor

As part of our efforts in regards to #1502, we should move NavigationServiceDelegate messaging-related logic (as well as other protocols of opportunity) into default protocol implementations so it's easier to roll your own NavigationViewController if need be.

This was previously impossible due to OBJ-C compatibility, but that blocker has been cleared as of #2230.

/cc @mapbox/navigation-ios
@JThramer JThramer added feature New feature request. release blocker Needs to be resolved before the release. size: M topic: architecture labels Nov 12, 2019
@JThramer JThramer added this to the v1.0.0 milestone Nov 12, 2019
@JThramer JThramer self-assigned this Nov 12, 2019
@1ec5 1ec5 added the backwards incompatible changes that break backwards compatibility of public API label Nov 13, 2019
@1ec5 1ec5 removed the release blocker Needs to be resolved before the release. label Jul 13, 2020
@1ec5 1ec5 removed this from the v1.0.0 milestone Sep 4, 2020
@truburt truburt removed the size: M label Sep 29, 2021
@JThramer JThramer removed their assignment Mar 2, 2023
@JThramer
Copy link
Contributor Author

JThramer commented Mar 2, 2023

Closing as stale.

@JThramer JThramer closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards incompatible changes that break backwards compatibility of public API feature New feature request. topic: architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JThramer @1ec5 @truburt