Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when attempting to use Custom navigation UI in Example app #2476

Closed
avi-c opened this issue Jul 20, 2020 · 3 comments · Fixed by #2478
Closed

Crash when attempting to use Custom navigation UI in Example app #2476

avi-c opened this issue Jul 20, 2020 · 3 comments · Fixed by #2478
Milestone
v1.0.0

Comments

@avi-c
Copy link
Contributor

avi-c commented Jul 20, 2020

The example app in the v1.0 pre-release branch in will crash if you select "Custom UI" as the option when starting a nav session.

I believe the issue is the XIB file for the CustomViewController contains references to some view classes that have been renamed for Swift, specifically:

MBInstructionsBannerView -> InstructionsBannerView
MBNavigationMapView -> NavigationMapView
@avi-c avi-c added the - crash label Jul 20, 2020
@1ec5 1ec5 added this to the v1.0.0 milestone Jul 20, 2020
@1ec5
Copy link
Contributor

1ec5 commented Jul 20, 2020

Likely a regression from #2230.

@MaximAlien
Copy link
Contributor

I think this ticket is the same to this one I've created some time ago. PR can be found here.

@MaximAlien MaximAlien mentioned this issue Jul 20, 2020
Merged
@avi-c
Copy link
Contributor Author

avi-c commented Jul 21, 2020

Agreed. Closing this ticket.

@MaximAlien MaximAlien linked a pull request Aug 21, 2020 that will close this issue
Fix crash in example app when using custom style UI. #2478
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Fix crash in example app when using custom style UI. mapbox/mapbox-navigation-ios
4 participants
@1ec5 @MaximAlien @dersim-davaod @avi-c