Use Tile::imageRect instead of cutting out tiles #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devnewton Since this is a follow-up on your PR #3339, I'd welcome any feedback. Apart from further simplifying the code, this is another step in the direction of resolving #1008. |
|
The code looks fine. When multi sized tiles will be available, I can adapt my tileset to test it. |
Now that we're storing a sub-rectangle for each tile, we can use it to avoid actually cutting out the tiles from the tileset image. Changing of a tile's image rect now also has its own undo command, and the tile image rect property is visible also for tiles from tileset-image based tilesets, though not editable for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're storing a sub-rectangle for each tile, we can use it to avoid actually cutting out the tiles from the tileset image.
Changing of a tile's image rect now also has its own undo command, and the tile image rect property is visible also for tiles from tileset-image based tilesets, though not editable for now.