YY plugin: Adjusted to changes in GameMaker file format #4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems an update to GameMaker in late 2024 has broken compatibility in several ways: * It now requires a "type tag field" at the start of applicable JSON records. * The name is expected to follow the "type tag field" as a "%Name" field, in addition to the regular "name" field. * Except for these special properties, the JSON fields are now required to be ordered alphabetically. Other minor differences include: * The "tags" field is left out when there are no tags. * There is no longer a space included after JSON field names. * Some new fields were added. This patch does not address all alphabetical ordering issues. Propably the preferred way will be to collect the fields in a QJsonObject first and rely on automatic sorting of the fields while serializing. Closes mapeditor#4132
|
Whoops, I forgot I had already opened a pull request for this. Anyway, this one is now superseded by #4143. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems an update to GameMaker in late 2024 has broken compatibility in several ways:
It now requires a "type tag field" at the start of applicable JSON records.
The name is expected to follow the "type tag field" as a "%Name" field, in addition to the regular "name" field.
Except for these special properties, the JSON fields are now required to be ordered alphabetically.
Other minor differences include:
This patch does not address all alphabetical ordering issues. Propably the preferred way will be to collect the fields in a QJsonObject first and rely on automatic sorting of the fields while serializing.
Closes #4132