Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when closing last document with properties selected #4160

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fixed crash when closing last document with properties selected #4160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### Unreleased

* Fixed potential crash when handling file reloads
* Fixed crash while handling file reloads without any files opened
* Fixed crash when closing the last file with multiple custom properties selected

### Tiled 1.11.1 (11 Jan 2025)

Expand Down
2 changes: 1 addition & 1 deletion src/tiled/propertieswidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ void PropertiesWidget::updateActions()
bool allCustomProperties = !items.isEmpty() && mPropertyBrowser->allCustomPropertyItems(items);
bool editingTileset = mDocument && mDocument->type() == Document::TilesetDocumentType;
bool isTileset = mPropertyBrowser->object() && mPropertyBrowser->object()->isPartOfTileset();
bool canModify = allCustomProperties && (!isTileset || editingTileset);
bool canModify = mDocument && allCustomProperties && (!isTileset || editingTileset);

// Disable remove and rename actions when none of the selected objects
// actually have the selected property (it may be inherited).
Expand Down
Loading