Fixed compile against Qt 6.8.2 and update packages to this version #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qt 6.8.2, a forward declaration was added for the QStringRef class from Qt 5, which breaks compilation because it is incompatible with the "using QStringRef = QStringView" line I was using for compatibility between Qt 5 and 6. Fortunately, as of Qt 5.15.2, the QStringView API is complete enough, so by raising the minimum required Qt version we no longer need QStringRef at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Qt 6.8.2, a forward declaration was added for the
QStringRefclass from Qt 5, which breaks compilation because it is incompatible with theusing QStringRef = QStringViewline I was using for compatibility between Qt 5 and 6.Fortunately, as of Qt 5.15.2, the
QStringViewAPI is complete enough, so by raising the minimum required Qt version we no longer needQStringRefat all.