Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other languages support #132

Open
Qomolang opened this issue May 27, 2022 · 4 comments
Open

Other languages support #132

Qomolang opened this issue May 27, 2022 · 4 comments

Comments

@Qomolang
Copy link

Does MapStruct have the reference guide in other language for now?

I have not found a Chinese version for MapStruct reference guide on the Internet, so I am trying to translate it into chinese.

In this progress, I find that the English reference guide is not a part of the MapStruct project On Github. And the English reference guide is not written in MardDown format. Is it possible to keep my translation format with the English reference guide?

Besides, would it be possible that I could have the honour to add the translation as a part of MapStruct reference guide?

@Qomolang Qomolang changed the title OtherLanguage Other languages support May 27, 2022
@filiphr
Copy link
Member

filiphr commented Aug 21, 2022

Does MapStruct have the reference guide in other language for now?

No currently, we do not have the guide in other languages. Mostly because it has never been requested.

In this progress, I find that the English reference guide is not a part of the MapStruct project On Github.

The reference guide of MapStruct is located in the main repository (https://github.com/mapstruct/mapstruct). More precisely in https://github.com/mapstruct/mapstruct/tree/main/documentation/src/main/asciidoc.

And the English reference guide is not written in MardDown format. Is it possible to keep my translation format with the English reference guide?

We are not using MarkDown, but rather Asciidoc.

Besides, would it be possible that I could have the honour to add the translation as a part of MapStruct reference guide?

Yes it would be possible to translate the guide in another language. Have a look at the links I shared. Feel free to provide a PR to the main repository with the translations. We are going to then include it on our website.
We won't be able to keep the translations up to date (since our lack of Chinese knowledge). Therefore, we would be grateful if you or someone else that knows Chinese can do that for us.

@Qomolang
Copy link
Author

Qomolang commented Sep 24, 2022

@filiphr hi~, I have done the translation for a mouth, now I am trying to change its style from MarkDown to Asciidoc

Besides, there is one thing that confuse me for some time -- Reference Guide examples seem not in MapStruct-examples?
If they are in MapStruct-examples, please let me know,
If they are not in, I would add them into MapStruct-examples.

@filiphr
Copy link
Member

filiphr commented Oct 7, 2022

@Qomolang what do you mean by "Reference Guide examples seen not in MapStruct-examples?".

The code snippets that are available in the reference guide are only code snippets nothing else. We can look into moving them to our repo and compiling them so that they can be shared between the different languages. How were you thinking to add them to the examples repo?

@Qomolang
Copy link
Author

Qomolang commented Oct 8, 2022

@filiphr thank you for the reply, I would add them to the examples repo so that the users can learn MapStruct more easily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants