Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new subject add command #183

Open
maxwai opened this issue Nov 14, 2023 · 5 comments · May be fixed by #197
Open

Add new subject add command #183

maxwai opened this issue Nov 14, 2023 · 5 comments · May be fixed by #197
Assignees
Labels
Command Adds a command Prio 2
Milestone

Comments

@maxwai
Copy link
Collaborator

maxwai commented Nov 14, 2023

Add command to create a new subject

@maxwai maxwai added Command Adds a command Prio 2 labels Nov 14, 2023
@maxwai maxwai added this to the SS23 milestone Nov 14, 2023
@byte-sized-emi
Copy link
Collaborator

byte-sized-emi commented Feb 7, 2024

I think I'd try to implement this and some of the other commands regarding subject's

@byte-sized-emi byte-sized-emi self-assigned this Feb 7, 2024
@byte-sized-emi
Copy link
Collaborator

How exactly should the usage be for this? "subject add" is already reserved for a user adding a new subject to themselves, the docs say "add new subject" - is that correct, as in "/add new subject"?

@maxwai
Copy link
Collaborator Author

maxwai commented Feb 8, 2024

This command would be subjects add (not the best I know). Without "s" the command is for users, with "s" for admins.

If you have a better naming scheme please feel free.

Also this command will be a prefix only command according to the docu

@byte-sized-emi
Copy link
Collaborator

maybe subject create/delete for admins and subject add/remove for users? But that's not really obvious because add and create are very synonymous... subject manage create/delete? That last one would probably make it more intuitive for users and less intuitive for admins, which I think is okay

@maxwai
Copy link
Collaborator Author

maxwai commented Feb 8, 2024

I think the manage Variant is a good solution, let's do it like this

@byte-sized-emi byte-sized-emi linked a pull request Feb 10, 2024 that will close this issue
4 tasks
@maxwai maxwai linked a pull request Feb 11, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command Adds a command Prio 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants