From ba9fab596aa4d98d6faf65999b1abf20cab366a8 Mon Sep 17 00:00:00 2001 From: "Marcos G. Zimmermann" Date: Wed, 10 Jul 2024 17:18:07 -0300 Subject: [PATCH] chore: fix rubocop offenses --- spec/esse/active_record/callback_spec.rb | 24 +++++++++++++++++++ .../callbacks/update_lazy_attribute_spec.rb | 2 +- spec/esse/active_record/callbacks_spec.rb | 23 ------------------ 3 files changed, 25 insertions(+), 24 deletions(-) create mode 100644 spec/esse/active_record/callback_spec.rb diff --git a/spec/esse/active_record/callback_spec.rb b/spec/esse/active_record/callback_spec.rb new file mode 100644 index 0000000..0b63470 --- /dev/null +++ b/spec/esse/active_record/callback_spec.rb @@ -0,0 +1,24 @@ +require 'spec_helper' + +RSpec.describe Esse::ActiveRecord::Callback do + let(:callback_class) do + Class.new(described_class) + end + let(:repo) { double } + + it 'raises an error if #call is not implemented' do + expect { + callback_class.new(repo: repo).call(nil) + }.to raise_error(NotImplementedError, 'You must implement #call method') + end + + it 'has options' do + callback = callback_class.new(repo: repo, foo: 'bar') + expect(callback.options).to eq(foo: 'bar') + end + + it 'has a block result' do + callback = callback_class.new(repo: repo, block_result: 'result') + expect(callback.block_result).to eq('result') + end +end diff --git a/spec/esse/active_record/callbacks/update_lazy_attribute_spec.rb b/spec/esse/active_record/callbacks/update_lazy_attribute_spec.rb index 8ce30de..de7a872 100644 --- a/spec/esse/active_record/callbacks/update_lazy_attribute_spec.rb +++ b/spec/esse/active_record/callbacks/update_lazy_attribute_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' RSpec.describe Esse::ActiveRecord::Callbacks::UpdateLazyAttribute do - let(:repo) { double('repo') } + let(:repo) { instance_double(Esse::Repository) } describe '.initialize' do it 'sets attribute_name' do diff --git a/spec/esse/active_record/callbacks_spec.rb b/spec/esse/active_record/callbacks_spec.rb index abab8b7..3dd59e7 100644 --- a/spec/esse/active_record/callbacks_spec.rb +++ b/spec/esse/active_record/callbacks_spec.rb @@ -62,26 +62,3 @@ end end end - -RSpec.describe Esse::ActiveRecord::Callback do - let(:callback_class) do - Class.new(described_class) - end - let(:repo) { double } - - it 'raises an error if #call is not implemented' do - expect { - callback_class.new(repo: repo).call(nil) - }.to raise_error(NotImplementedError, 'You must implement #call method') - end - - it 'has options' do - callback = callback_class.new(repo: repo, foo: 'bar') - expect(callback.options).to eq(foo: 'bar') - end - - it 'has a block result' do - callback = callback_class.new(repo: repo, block_result: 'result') - expect(callback.block_result).to eq('result') - end -end