From c9a3b1d6de1dc6a3bf8910aedafa012dc53d5524 Mon Sep 17 00:00:00 2001 From: "Marcos G. Zimmermann" Date: Wed, 10 Jul 2024 17:13:01 -0300 Subject: [PATCH] chore: fix rubocop offenses --- spec/esse/active_record/callbacks_spec.rb | 4 ++-- spec/esse/active_record/model/esse_callback_spec.rb | 10 +++++++--- .../model/update_lazy_attribute_callback_spec.rb | 12 ++++++------ 3 files changed, 15 insertions(+), 11 deletions(-) diff --git a/spec/esse/active_record/callbacks_spec.rb b/spec/esse/active_record/callbacks_spec.rb index 631973e..abab8b7 100644 --- a/spec/esse/active_record/callbacks_spec.rb +++ b/spec/esse/active_record/callbacks_spec.rb @@ -39,12 +39,12 @@ describe '.registered?' do it 'returns false if the callback is not registered' do - expect(described_class.registered?(:external, :create)).to eq(false) + expect(described_class.registered?(:external, :create)).to be(false) end it 'returns true if the callback is registered' do described_class.register_callback(:external, :create, Class.new(Esse::ActiveRecord::Callback)) - expect(described_class.registered?(:external, :create)).to eq(true) + expect(described_class.registered?(:external, :create)).to be(true) end end diff --git a/spec/esse/active_record/model/esse_callback_spec.rb b/spec/esse/active_record/model/esse_callback_spec.rb index 28f5c06..57ed9ac 100644 --- a/spec/esse/active_record/model/esse_callback_spec.rb +++ b/spec/esse/active_record/model/esse_callback_spec.rb @@ -14,13 +14,17 @@ def self.clear Thread.current[:dummy_callback_repo] = nil end end + class DumpTempCallback < Esse::ActiveRecord::Callback def call(model) DummyCallbackRepo.add [model, options, block_result] end end + class DumpTempCallbackOnCreate < DumpTempCallback; end + class DumpTempCallbackOnUpdate < DumpTempCallback; end + class DumpTempCallbackOnDestroy < DumpTempCallback; end RSpec.describe Esse::ActiveRecord::Model, '.esse_callback' do @@ -85,7 +89,7 @@ class DumpTempCallbackOnDestroy < DumpTempCallback; end model_class.esse_callback('states:state', :temp, on: %i[create], custom: 'value') { :ok } expect(model_class.esse_callbacks).to a_hash_including( 'states:state' => a_hash_including( - temp_on_create: match_array([DumpTempCallbackOnCreate, {custom: 'value'}, an_instance_of(Proc)]), + temp_on_create: contain_exactly(DumpTempCallbackOnCreate, {custom: 'value'}, an_instance_of(Proc)), ) ) end @@ -132,7 +136,7 @@ class DumpTempCallbackOnDestroy < DumpTempCallback; end model_class.esse_callback('states:state', :temp, on: %i[update], custom: 'value') { :ok } expect(model_class.esse_callbacks).to a_hash_including( 'states:state' => a_hash_including( - temp_on_update: match_array([DumpTempCallbackOnUpdate, {custom: 'value'}, an_instance_of(Proc)]), + temp_on_update: contain_exactly(DumpTempCallbackOnUpdate, {custom: 'value'}, an_instance_of(Proc)), ) ) end @@ -182,7 +186,7 @@ class DumpTempCallbackOnDestroy < DumpTempCallback; end model_class.esse_callback('states:state', :temp, on: %i[destroy], custom: 'value') { :ok } expect(model_class.esse_callbacks).to a_hash_including( 'states:state' => a_hash_including( - temp_on_destroy: match_array([DumpTempCallbackOnDestroy, {custom: 'value'}, an_instance_of(Proc)]), + temp_on_destroy: contain_exactly(DumpTempCallbackOnDestroy, {custom: 'value'}, an_instance_of(Proc)), ) ) end diff --git a/spec/esse/active_record/model/update_lazy_attribute_callback_spec.rb b/spec/esse/active_record/model/update_lazy_attribute_callback_spec.rb index 8a401fd..8a5dc9d 100644 --- a/spec/esse/active_record/model/update_lazy_attribute_callback_spec.rb +++ b/spec/esse/active_record/model/update_lazy_attribute_callback_spec.rb @@ -35,9 +35,9 @@ model_class.update_lazy_attribute_callback('states:state', :field, custom: 'value') { :ok } expect(model_class.esse_callbacks).to a_hash_including( 'states:state' => a_hash_including( - update_lazy_attribute_on_create: match_array([Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)]), - update_lazy_attribute_on_update: match_array([Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)]), - update_lazy_attribute_on_destroy: match_array([Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)]), + update_lazy_attribute_on_create: contain_exactly(Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)), + update_lazy_attribute_on_update: contain_exactly(Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)), + update_lazy_attribute_on_destroy: contain_exactly(Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)), ) ) end @@ -52,7 +52,7 @@ model_class.update_lazy_attribute_callback('states:state', :field, on: %i[create], custom: 'value') { :ok } expect(model_class.esse_callbacks).to a_hash_including( 'states:state' => a_hash_including( - update_lazy_attribute_on_create: match_array([Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)]), + update_lazy_attribute_on_create: contain_exactly(Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)), ) ) end @@ -68,7 +68,7 @@ model_class.update_lazy_attribute_callback('states:state', :field, on: %i[update], custom: 'value') { :ok } expect(model_class.esse_callbacks).to a_hash_including( 'states:state' => a_hash_including( - update_lazy_attribute_on_update: match_array([Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)]), + update_lazy_attribute_on_update: contain_exactly(Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)), ) ) end @@ -84,7 +84,7 @@ model_class.update_lazy_attribute_callback('states:state', :field, on: %i[destroy], custom: 'value') { :ok } expect(model_class.esse_callbacks).to a_hash_including( 'states:state' => a_hash_including( - update_lazy_attribute_on_destroy: match_array([Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)]), + update_lazy_attribute_on_destroy: contain_exactly(Esse::ActiveRecord::Callbacks::UpdateLazyAttribute, { attribute_name: :field, custom: 'value'}, an_instance_of(Proc)), ) ) end