diff --git a/spec/esse/integrations/elasticsearch-5/transport/update_by_query_spec.rb b/spec/esse/integrations/elasticsearch-5/transport/documents_update_by_query_spec.rb similarity index 75% rename from spec/esse/integrations/elasticsearch-5/transport/update_by_query_spec.rb rename to spec/esse/integrations/elasticsearch-5/transport/documents_update_by_query_spec.rb index 63c62e7..9240c73 100644 --- a/spec/esse/integrations/elasticsearch-5/transport/update_by_query_spec.rb +++ b/spec/esse/integrations/elasticsearch-5/transport/documents_update_by_query_spec.rb @@ -4,5 +4,5 @@ require 'support/shared_examples/transport_update_by_query' stack_describe 'elasticsearch', '5.x', Esse::Transport, '#update_by_query' do - include_examples 'transport#update_by_query' + include_examples 'transport#update_by_query', doc_type: true end diff --git a/spec/esse/integrations/elasticsearch-6/transport/update_by_query_spec.rb b/spec/esse/integrations/elasticsearch-6/transport/documents_update_by_query_spec.rb similarity index 75% rename from spec/esse/integrations/elasticsearch-6/transport/update_by_query_spec.rb rename to spec/esse/integrations/elasticsearch-6/transport/documents_update_by_query_spec.rb index e512a4d..9328280 100644 --- a/spec/esse/integrations/elasticsearch-6/transport/update_by_query_spec.rb +++ b/spec/esse/integrations/elasticsearch-6/transport/documents_update_by_query_spec.rb @@ -4,5 +4,5 @@ require 'support/shared_examples/transport_update_by_query' stack_describe 'elasticsearch', '6.x', Esse::Transport, '#update_by_query' do - include_examples 'transport#update_by_query' + include_examples 'transport#update_by_query', doc_type: true end diff --git a/spec/esse/integrations/elasticsearch-7/transport/update_by_query_spec.rb b/spec/esse/integrations/elasticsearch-7/transport/documents_update_by_query_spec.rb similarity index 100% rename from spec/esse/integrations/elasticsearch-7/transport/update_by_query_spec.rb rename to spec/esse/integrations/elasticsearch-7/transport/documents_update_by_query_spec.rb diff --git a/spec/esse/integrations/elasticsearch-8/transport/update_by_query_spec.rb b/spec/esse/integrations/elasticsearch-8/transport/documents_update_by_query_spec.rb similarity index 100% rename from spec/esse/integrations/elasticsearch-8/transport/update_by_query_spec.rb rename to spec/esse/integrations/elasticsearch-8/transport/documents_update_by_query_spec.rb diff --git a/spec/support/shared_examples/transport_update_by_query.rb b/spec/support/shared_examples/transport_update_by_query.rb index 79e6230..5f2feb9 100644 --- a/spec/support/shared_examples/transport_update_by_query.rb +++ b/spec/support/shared_examples/transport_update_by_query.rb @@ -1,6 +1,9 @@ # frozen_string_literal: true -RSpec.shared_examples 'transport#update_by_query' do +RSpec.shared_examples 'transport#update_by_query' do |doc_type: false| + let(:params) do + doc_type ? { type: 'geo' } : {} + end let(:body) do { settings: { @@ -18,7 +21,7 @@ expect(client).not_to receive(:perform_request) cluster.readonly = true expect { - cluster.api.update_by_query(index: "#{cluster.index_prefix}_redonly", body: { script: { source: 'ctx._source.title = "foo"' } }, q: '*') + cluster.api.update_by_query(**params, index: "#{cluster.index_prefix}_redonly", body: { script: { source: 'ctx._source.title = "foo"' } }, q: '*') }.to raise_error(Esse::Transport::ReadonlyClusterError) end end @@ -26,7 +29,7 @@ it 'raises an #