Merge pull request #10549 from marmelab/fix/tabbedform_tabs_should_ac…

…cept_onChange Make `<TabbedForm tabs>` use the `onChange` prop
marmelab · Feb 26, 2025 · 67f534b · 67f534b
2 parents 0fcfb7c + e76452f
commit 67f534b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/packages/ra-ui-materialui/src/form/TabbedForm.spec.tsx b/packages/ra-ui-materialui/src/form/TabbedForm.spec.tsx
@@ -20,7 +20,8 @@ import { AdminContext } from '../AdminContext';
 import { TabbedForm } from './TabbedForm';
 import { TabbedFormClasses } from './TabbedFormView';
 import { TextInput } from '../input';
-import { EncodedPaths } from './TabbedForm.stories';
+import { EncodedPaths, MultipleTabs } from './TabbedForm.stories';
+import { TabbedFormTabs } from './TabbedFormTabs';
 
 describe('<TabbedForm />', () => {
     it('should display the tabs', () => {
@@ -313,4 +314,15 @@ describe('<TabbedForm />', () => {
             expect.stringContaining(`at ${TabbedForm.name}`)
         );
     });
+
+    it('should accept a "onChange" prop on the tabs', async () => {
+        const onChange = jest.fn();
+        render(<MultipleTabs tabs={<TabbedFormTabs onChange={onChange} />} />);
+
+        await screen.findByDisplayValue('War and Peace');
+        const tabs = screen.getAllByRole('tab');
+        fireEvent.click(tabs[1]);
+        expect(onChange).toBeCalledTimes(1);
+        expect(onChange).toBeCalledWith(expect.anything(), '1'); // tab index
+    });
 });
diff --git a/packages/ra-ui-materialui/src/form/TabbedForm.stories.tsx b/packages/ra-ui-materialui/src/form/TabbedForm.stories.tsx
@@ -71,9 +71,9 @@ export const Basic = () => (
     </Wrapper>
 );
 
-export const MultipleTabs = () => (
+export const MultipleTabs = ({ tabs }) => (
     <Wrapper>
-        <TabbedForm>
+        <TabbedForm tabs={tabs}>
             <TabbedForm.Tab label="main">
                 <TextInput source="title" />
                 <TextInput source="author" />

diff --git a/packages/ra-ui-materialui/src/form/TabbedFormView.tsx b/packages/ra-ui-materialui/src/form/TabbedFormView.tsx
@@ -37,6 +37,9 @@ export const TabbedFormView = (props: TabbedFormViewProps): ReactElement => {
         if (!syncWithLocation) {
             setTabValue(value);
         }
+        if (tabs.props.onChange) {
+            tabs.props.onChange(event, value);
+        }
     };
 
     const renderTabHeaders = () =>