Merge pull request #63 from BenBE/fix-evhadler-uaf

masterzen · web-flow · commit 463d60b5024d · 2025-03-12T23:34:05.000+01:00
Fix UAF in `ngx_http_uploadprogress_event_handler`
diff --git a/ngx_http_uploadprogress_module.c b/ngx_http_uploadprogress_module.c
@@ -502,9 +502,9 @@ static void ngx_http_uploadprogress_event_handler(ngx_http_request_t *r)
 
 
     if (shm_zone == NULL) {
-        ngx_http_uploadprogress_strdupfree(id);
         ngx_log_debug1(NGX_LOG_DEBUG_HTTP, ngx_cycle->log, 0,
                        "upload-progress: read_event_handler no shm_zone for id: %V", id);
+        ngx_http_uploadprogress_strdupfree(id);
         return;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -502,9 +502,9 @@ static void ngx_http_uploadprogress_event_handler(ngx_http_request_t *r)`
`502`	`502`
`503`	`503`
`504`	`504`	`if (shm_zone == NULL) {`
`505`		`- ngx_http_uploadprogress_strdupfree(id);`
`506`	`505`	`ngx_log_debug1(NGX_LOG_DEBUG_HTTP, ngx_cycle->log, 0,`
`507`	`506`	`"upload-progress: read_event_handler no shm_zone for id: %V", id);`
	`507`	`+ ngx_http_uploadprogress_strdupfree(id);`
`508`	`508`	`return;`
`509`	`509`	`}`
`510`	`510`