Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefinition of the ASE Atoms class in pymatgen.io.ase is problematic with type checkers #4282

Open
tomdemeyere opened this issue Feb 6, 2025 · 0 comments

Comments

@tomdemeyere
Copy link
Contributor

class Atoms:  # type: ignore[no-redef]
    def __init__(self, *args, **kwargs):
        raise NO_ASE_ERR

In my code I would then have ""pymatgen.io.ase.Atoms" is not assignable to "ase.atoms.Atoms"" everywhere, because the type checker is confused about the redefinition. Is it really necessary to have this DummyClass defined there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant