Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspected little error in: pymatgen/transformations/advanced_transformations.py #4318

Open
jonasarnum opened this issue Mar 7, 2025 · 0 comments
Labels

Comments

@jonasarnum
Copy link

Python version

3.12.4

Pymatgen version

2024.10.3

Operating system version

No response

Current behavior

In the class EnumerateStructureTransformation (defined in pymatgen/transformations/advanced_transformations.py), the M3GNetCalculator is called like this:
m3gnet_model = M3GNetCalculator(potential=potential, stress_weight=0.01).
However, the stress_weight value should be either 1.0 (for GPa) or 1 / 160.21766208 (for eV/A^3).

Expected Behavior

Either:
m3gnet_model = M3GNetCalculator(potential=potential). (--> default value of 1.0 would be used),
or:
m3gnet_model = M3GNetCalculator(potential=potential, stress_weight=1/160.21766208).

Minimal example

Since it is not a bug but an eventual little mistake, no code snippet is provided.

Relevant files to reproduce this bug

Since it is not a bug but an eventual little mistake, no file is provided.

@jonasarnum jonasarnum added the bug label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant