Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove types.list RPC method #3827

Closed
seancolsen opened this issue Sep 12, 2024 · 1 comment · Fixed by #3984
Closed

Remove types.list RPC method #3827

seancolsen opened this issue Sep 12, 2024 · 1 comment · Fixed by #3984
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Milestone
v0.2.0 (beta rele...

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Sep 12, 2024 •
edited
Loading

In #3676 we added a types.list method here.

Then in #3800 we moved this functionality to the front end by hard-coding the response there.

We should remove the functionality from the backend and all orphaned code as a result.
@seancolsen seancolsen added ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: backend Related to Python, Django, and simple SQL labels Sep 12, 2024
@seancolsen seancolsen added this to the Beta milestone Sep 12, 2024
@seancolsen
Copy link
Contributor Author

@mathemancer perhaps you would like to take this as part of your dead code removal?

This was referenced Oct 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Projects
None yet
Milestone
v0.2.0 (beta release)
Development

Successfully merging a pull request may close this issue.

Remove types.list RPC endpoint mathesar-foundation/mathesar
1 participant
@seancolsen