Implement roles.delete, databases.drop & databases.configured.disconnect endpoints
#3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavish
approved these changes
Sep 23, 2024
Comment on lines
+63
to
+72
| """ | ||
| Drop a database from the server. | ||
|
|
||
| Args: | ||
| database_oid: The OID of the database to delete on the database. | ||
| database_id: The Django id of the database to connect to. | ||
| """ | ||
| user = kwargs.get(REQUEST_KEY).user | ||
| with connect(database_id, user) as conn: | ||
| drop_database(database_oid, conn) |
There was a problem hiding this comment.
I've been thinking more about this and we should only be providing delete for databases created in the internal server. Only Mathesar admins should be able to perform this.
When the user requests a delete, these conditions should match:
- The user should be a Mathesar admin
- The database should be present within the internal db server
- The collaborator must use a role that owns the database
And then, in a single transaction:
- connect to the database that's about to be deleted
- change ownership to the internal db role that we use in mathesar_django
- disconnect
- connect to the internal db server with the internal db role
- drop the database
There was a problem hiding this comment.
Nothing needed in this PR, we can do this for beta.
Comment on lines
+65
to
+66
| database_qs = Database.objects.get(id=database_id) | ||
| database_qs.delete() |
There was a problem hiding this comment.
We need to discuss on how to remove the Mathesar schemas. This requires a broader discussion on how we'll retain/request the user for the role & password for the role that owns the schemas.
We can get back to this before beta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3772
Fixes #3841
Fixes #3842
Checklist
Update index.md).developbranch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin