Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room creation repeated. #1

Open
ar1a opened this issue Aug 1, 2017 · 2 comments
Open

Room creation repeated. #1

ar1a opened this issue Aug 1, 2017 · 2 comments

Comments

@ar1a
Copy link

ar1a commented Aug 1, 2017

If a room has not been created yet, and multiple messages are sent quickly, the script will try to create a room for every single message, until the first one is created and set (and then itll just send them to that one).

Which leaves a few empty servers that were made but abandoned. An idea would be to either clean these up, or maybe make sure only one room is being made at a time.

@Sorunome
Copy link
Member

Sorunome commented Aug 1, 2017

This is....rather complex due to everything beeing asyncrone and stuff, and it is an edge case so don't expect a fix for this soon

@kfatehi
Copy link
Member

kfatehi commented Aug 2, 2017

Everything should probably go through a queue. this may help https://www.npmjs.com/package/queue

we use it in the imessage bridge but i think using it in the puppet server may be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants