Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fullscreen size but not fullscreen, after restart of app #3285

Open
6 tasks done
movahhedi opened this issue Jan 21, 2025 · 3 comments
Open
6 tasks done

[Bug]: Fullscreen size but not fullscreen, after restart of app #3285

movahhedi opened this issue Jan 21, 2025 · 3 comments

Comments

@movahhedi
Copy link

movahhedi commented Jan 21, 2025

Checks before filing an issue

Mattermost Desktop Version

5.10.2

Operating System

Windows 11 x64

Mattermost Server Version

10.2.0

Steps to reproduce

  1. Open Mattermost Desktop
  2. Make it full screen
  3. Exit it fully from the tray
  4. Open it again
  5. Minimize it
  6. Open it again (maximize it)

The windows is not roughly the size of fullscreen, but it is not. and causes clicks at the corners and edges to affect the other windows behind.

This is especially painful when clicking on the far top-right corner to close it, but then you accidentally close the fullscreen window behind it.

Expected behavior

Fullscreen stays fullscreen after app restart, or maintains the smaller size that it normally would be. NOT nearly fullscreen size but not fullscreen

This screenshot is from the exact far top-right of the screen.
Image

Observed behavior

Fullscreen size but not fullscreen.

This screenshot is from the exact far top-right of the screen.
Image
As you can see, the windows has a small distance from the corner; sometimes it's more left (like the image), and sometimes more right (like below).

Image

Log Output

---

Additional Information

Please.
I'm hurting...

@movahhedi movahhedi changed the title [Bug]: [Bug]: Fullscreen size but not fullscreen, after restart of app Jan 21, 2025
@devinbinnie
Copy link
Member

Does this reproduce on older versions of the app or is this a regression in the newest one? This could be an Electron bug.

Have you tried other machines? Curious if it's just one machine or multiple showing this behaviour.

Do you have some kind of scaling turned on? Electron doesn't often play well with scaling despite some fixes we've made.

@movahhedi
Copy link
Author

I've had this bug for as long as I use the desktop app. At least 2 years. Always updated.

I use many apps that use Electron. None have this problem.

No scaling or related settings. Have this problem on all the 3 devices I use, and my colleagues too.

I searched "fullscreen" in the repo, it is used in many places. I think the code tries to remember its state, but doesn't remember that the state was "fullscreen". It shouldn't remember the dimensions when it is fullscreen; only the fact that it is fullscreen is needed.

@devinbinnie
Copy link
Member

Okay I seem to be able to reproduce this - though it doesn't happen in fullscreen mode it happens when you maximize (since you can't access the tray when you full screen).

Created a ticket: https://mattermost.atlassian.net/browse/MM-62680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants