Skip to content

Commit 0532050

Browse files
committed
Remove "user env compile" test
This test was added to ensure that we didn't accidentally write-over a user's environment variables when we first introduced "user env compile" as a default. It's no longer needed and Rails 4.0 apps cannot install with Ruby 2.4 or 2.5 and that is the only currently available rubies on Heroku 18.
1 parent 32ac3ae commit 0532050

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

hatchet.json

-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
"sharpstone/rails4-manifest",
6060
"sharpstone/rails3-to-4-no-bin",
6161
"sharpstone/rails4_windows_mri193",
62-
"sharpstone/rails4-env-assets-compile",
6362
"sharpstone/rails4-fail-assets-compile"
6463
],
6564
"rails41": [

hatchet.lock

-2
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@
6161
- 8cc041cffb9f5635017aa118d16688491f794e91
6262
- - "./repos/rails4/rails3-to-4-no-bin"
6363
- 3fd6e84f5d8eaaadb6d95aeb1f367f62da28cc62
64-
- - "./repos/rails4/rails4-env-assets-compile"
65-
- ba8c352856685c3e46ae227ffbc175d6aa8e868b
6664
- - "./repos/rails4/rails4-fail-assets-compile"
6765
- 7f65fbb04ca49be526906a1b0d9155cd24941b8e
6866
- - "./repos/rails4/rails4-manifest"

spec/hatchet/rails4_spec.rb

-9
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,4 @@
8686
expect(app).not_to be_deployed
8787
end
8888
end
89-
90-
it "should not override user settings rails 4.2" do
91-
app = Hatchet::Runner.new("rails4-env-assets-compile")
92-
app.setup!
93-
app.set_config("RAILS_ENV" => "staging")
94-
app.deploy do |a, heroku|
95-
expect(a.output).to include("w00t")
96-
end
97-
end
9889
end

0 commit comments

Comments
 (0)