mouseup outside a modal always closes it
#1869
Labels
Community
This is a great issue for community members to work on
3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
Comments
zachgoll
added
3️⃣ Low priority
zachgoll
pushed a commit
that referenced
this issue
Mar 3, 2025
* Replaced data-action click event with data-action mousedown to prevent the modal from hiding on mouse up whenever mouse down starts within the modal * Changed click events to mousedown within dialog elements to trigger the closing of the element
|
Fixed via #1931 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Releasing the mouse from outside a modal always closes it, even when the mouse was pressed from inside the modal. Dragging motions to the outside feel common with certain UIs like color pickers, so it would be annoying to close unintentionally, especially if there was more information written in a previous window.
category.flow.modal.mouseup.mp4
My thoughts are to make the
modalview close iff the mouse was pressed and released from outside, something along the lines of astopPropagationcall /:stopaction on the<dialog>'s only child and adding a flag to the modal controller that gets set on mouse down.Originally posted by @goldenstein64 in #1857 (comment)
The text was updated successfully, but these errors were encountered: