Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Mapping crashing with empty stream #1924

Open
1 task
edgarrmondragon opened this issue Aug 23, 2023 · 1 comment
Open
1 task

bug: Mapping crashing with empty stream #1924

edgarrmondragon opened this issue Aug 23, 2023 · 1 comment
Labels
Accepting Pull Requests good first issue Good for newcomers kind/Bug Something isn't working valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

Singer SDK Version

0.31.1

Is this a regression?

  • Yes

Python Version

NA

Bug scope

Mapping (stream maps, flattening, etc.)

Operating System

NA

Description

MeltanoLabs/meltano-map-transform#164

Code

No response
@edgarrmondragon edgarrmondragon added kind/Bug Something isn't working valuestream/SDK labels Aug 23, 2023
@edgarrmondragon
Copy link
Collaborator Author

Fixing this should be as simple as using .get(...) in

sdk/singer_sdk/mapper.py

Lines 489 to 490 in 46c14f6

or self.raw_schema["properties"].get(prop_def, {})
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting Pull Requests good first issue Good for newcomers kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edgarrmondragon