Display battery usage on bluetooth radio screen #848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72A12F4E
reviewed
Aug 11, 2024
| import Foundation | ||
| import MeshtasticProtobufs | ||
|
|
||
| class BatteryHelper { |
There was a problem hiding this comment.
this can be an enum, since we won't ever need to instantiate an instance of BatteryHelper
|
LGTM overall |
|
I would rather use the existing battery level indicator that is on the node list, under the circle. There is also a new lastest device metrics extension on node that you can use to get the battery data. |
|
Battery indicator from node details has been added to the bluetooth screen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This change adds the battery level to the bluetooth radio status screen. The discussion came up in #837. Closes #847
Why did it change?
I felt the battery status should be surfaced more conveniently, since it is a common value to be looking at.
Screenshots/Videos (when applicable)
Checklist