MeshMap: add setting to hide location precision circles #921
Conversation
powersjcb
changed the title
|
I'm blocked testing this change at the moment since I don't have the ability to load real node data. update: resolved - will open a PR documenting how to get the app building for an iphone without being added to the core contributor group |
| @@ -96,6 +97,9 @@ extension UserDefaults { | |||
|
|
|||
| @UserDefault(.meshMapDistance, defaultValue: 800000) | |||
| static var meshMapDistance: Double | |||
|
|
|||
| @UserDefault(.meshMapShowLocationPrecision, defaultValue: true) | |||
There was a problem hiding this comment.
there's three default values related to these configs (which is a bit confusing)
|
I finally figured out how to get this compiling for my phone. However, even with the business logic disabled that hides location precision I'm only seeing a circle on the map for my own node. TBD what's going on here, but I suspect we only ingest position precision when the iphone app sees certain events have happened. |
|
At the moment, this is just an attempt to allow users to "opt-out of clutter" if they don't care about knowing how precise node positions are. See this example where entire regions of the map are filled by Location Precision Circles for nodes that have ranges of 5mi and 15mi. When zoomed in the entire map has fill colors driven by the two nodes. 
@garthvh, as a more minimalist change, what would you think about removing or allowing users to toggle fill color for Location Precision Circles? This wouldn't change the ability to see uncertainty, but it would prevent very large Location Precision Circles from applying fill color for all the areas of the map they encapsulate. (which can contain many nodes) Separately, do you have any sense for how stable we are with this UI? Given the comments on reddit, it feels like it would be helpful to build a tooltip map-legend UI once it's stable.
|
|
This might need some tweaks to edge color to make it more visible, but it doesn't mess with the map colors within the bounds of the circle. 
|
|
I really am not seeing a need for this right now, the circles are like 20% and several can stack fine on top of each other. May revisit after 2.5 is the majority firmware. |
Resolves: #920
What changed?
Added menu option to hide location precision circles for nodes
Why did it change?
Allows for cleaner UIs when map areas have users with very low location precision
How is this tested?
Manually on iPhone
Screenshots/Videos (when applicable)
RPReplay_Final1725837447.mov
Checklist