Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhone X in landscape mode #23

Open
winzig opened this issue Sep 19, 2018 · 4 comments
Open

iPhone X in landscape mode #23

winzig opened this issue Sep 19, 2018 · 4 comments

Comments

@winzig
Copy link

winzig commented Sep 19, 2018

When in landscape mode on iPhone X (and presumably XS, XS Max, XR though I don't have those to test with at the moment), the fullscreen dark background doesn't extend fully to the sides of the display. Instead you see your website background bleeding through on the sides.

The issue in general is illustrated on this page, though I hope there's also a CSS-specific fix that could be applied to flickity-fullscreen, rather than our entire website design.

The image gives you a sense of the issue:

iphonexspacegrey_landscape

I am able to reproduce this problem on the fullscreen demo page.

@desandro
Copy link
Member

Thanks for reporting this issue. This looks to be a browser bug. Mobile safari itself does not allow its webview to expand into the notch area. Bummer. 😩

@winzig
Copy link
Author

winzig commented Sep 20, 2018

@desandro Unless I'm misunderstanding what you mean, I don't think this is necessarily true. I changed the viewport on the page as described in the page I linked to on the codepen sample, and this works:

<meta name="viewport" content="width=device-width, initial-scale=1.0, viewport-fit=cover">

screen shot 2018-09-20 at 1 30 36 pm

My pen is here: https://codepen.io/tomwinzig/pen/YOBgEQ

In our case we don't want our entire site content to bleed into those zones, so we can't use the viewport fix for the issue, but perhaps there is an equivalent effect that can be applied on just the flickity fullscreen divs?

@desandro
Copy link
Member

Ah! I did not know about viewport-fit. You could try changing it dynamically on fullscreenChange

@winzig
Copy link
Author

winzig commented Sep 21, 2018

I experimented with trying to use @viewport in CSS, but was unable to get that to work. If I could get that working, then I was going to experiment with changing the CSS dynamically in fullscreenChange, but didn't get that far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants