Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major glitches when you try to change fullscreen status when the carousel is moving #32

Open
nkalupahana opened this issue Jan 4, 2022 · 5 comments · May be fixed by #33
Open

Major glitches when you try to change fullscreen status when the carousel is moving #32

nkalupahana opened this issue Jan 4, 2022 · 5 comments · May be fixed by #33

Comments

@nkalupahana
Copy link

If you go the demo, click the next button on the carousel, and then immediately click the fullscreen button, instead of seeing the fullscreen carousel, you'll see a black image. Similarly, if you drag the carousel while it's in fullscreen and then click the button to exit, the carousel image will disappear.

This bug makes this functionality unusable, and any insight into why it might be happening would be greatly appreciated.
nkalupahana added a commit to nkalupahana/flickity-fullscreen that referenced this issue Jan 4, 2022
@nkalupahana
Fix metafizzy#32
22f40e7
@nkalupahana nkalupahana linked a pull request Jan 4, 2022 that will close this issue
Open
@AndreasDeRijcke
Copy link

I confirm both the issue and the patch having the desired result.

@txrris
Copy link

txrris commented Feb 28, 2022 •
edited
Loading

This is NOT fixed, issue is still present on the demo

@nkalupahana
Copy link
Author

nkalupahana commented Feb 28, 2022 •
edited
Loading

@txrris Yes, it is not -- that's what PR #33 is for, which hopefully will eventually get merged :/
Until then, feel free to use my fork of the package, which has the fix.

@Alexandre-dcm
Copy link

Thx a lot for the fix @nkalupahana

@mattneal-stafflink
Copy link

Any updates on this? The problem still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #32 nkalupahana/flickity-fullscreen
5 participants
@AndreasDeRijcke @nkalupahana @txrris @mattneal-stafflink @Alexandre-dcm