Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria-hidden attribute incorrectly applied when more than one cell in view #1015

Open
jasonwbullok opened this issue Jan 21, 2020 · 1 comment
Open

Aria-hidden attribute incorrectly applied when more than one cell in view #1015

jasonwbullok opened this issue Jan 21, 2020 · 1 comment

Comments

@jasonwbullok
Copy link

When more than one cell is visible, only the currently selected cell is exempt from having an aria-hidden: true attribute affixed. This is non-compliant in instances where more than one cell is in view.

The carousel would have to know which cells are inside/outside the viewport to correctly apply the attribute. @desandro called this out explicitly in this thread: #774 (comment)
(which refs issue 638)

Test case: https://codepen.io/jasonwbullok/pen/bGNOrpa
(e.g. inspect cell number two to see the aria-hidden: true attribute)
@desandro
Copy link
Member

This is indeed an issue. PR #1032 could resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@desandro @jasonwbullok