-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for pinch to zoom #116
Comments
Hi! Thanks for the feature request. I'd like to focus on Flickity's core carousel feature set, rather than get into a full-scale image gallery. I recommend using PhotoSwipe as an alternative. |
Hi @desandro I really like your code and proejects and I would want you to know that there is lack of good photo gallery plugins out there,
so as you gave PhotoSwipe as example its really good as a base minimum plugin, but once you want basic stuff like thumbnails supports - you cant, or you want a bit more advanced stuff like wrapAround, freeScroll etc you just cant I think there is good market opportunity to release a photo gallery plugin to sit on top of flickity, the only thing that missing is pinch to zoom on the other ends there is full big galleries like Swiper, that weight 33kb gzip |
@boynet I agree @desandro's plugins are some of the best available. Unfortunately, they are currently in "open source" where programmers like us are responsible for improving the plugins. Not sure if you have seen metafizzy/flickity-fullscreen#20 but there is some additional information about getting pinch to zoom working. |
@clarknelson Did you get any closer with this? I find pinch-zooming and then trying to pan the image actually changes slides. Is it possible to block slide changing when zoomed in somehow? |
No I didn't really modify any code in the library. I think the best solution is to disable |
@clarknelson I was trying to combine this with a jQuery plugin called imgViewer2 to get pinch to zoom to work, but pinching does not trigger zoom. My customer didn't think it was important enough to spend hours on, so I have also let the thought go for now. |
I was able to achieve this with a single line of CSS. You'll need to add custom carousel controls outside of the carousel element if you actually want to be able to control the carousel. You can also only apply this CSS at the mobile breakpoint to allow draggable carousels on desktop. .carousel {
pointer-events: none;
} |
Hey @desandro, what do you think about integrating touch interactions to zoom in/out to images?
The text was updated successfully, but these errors were encountered: