Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible bump with lazyLoad and adaptiveHeight both enabled #670

Closed
ryanburnette opened this issue Dec 28, 2017 · 2 comments
Closed

Visible bump with lazyLoad and adaptiveHeight both enabled #670

ryanburnette opened this issue Dec 28, 2017 · 2 comments

Comments

@ryanburnette
Copy link

ryanburnette commented Dec 28, 2017

If you enable lazyLoad and adaptiveHeight at the same time, you get a bump, albeit an expected one where the adaptive height feature fires on the slide without its image loaded. The adaptive height feature fires again when the image loads, but there is a more graceful transition that could occur here.

What do you think, @desandro? Is this something you might consider addressing? One thought I have is just to hold at least the height of the previous element until the image loads on the next slide. Some ideas on how to hook into the plugin to configure a different approach could also be helpful.

My issue has some distant connection to #430. If lazy loading could always be a certain number of slides ahead, this issue would also be solved, at least enough to improve my user experience.

The test case isn't optimal because the images load quickly, you have to look closely for the bump I'm talking about.

Test case: https://codepen.io/ryanburnette/pen/rpyqNV

@desandro
Copy link
Member

Hello! Thanks for reporting this issue. The best solution is to set lazyLoad: 1, so the next adjacent slide's images are loaded.

@ryanburnette
Copy link
Author

ryanburnette commented Dec 31, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants