Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to handle multiple selected cells #961

Closed
NikxDa opened this issue Jul 2, 2019 · 1 comment
Closed

Ability to handle multiple selected cells #961

NikxDa opened this issue Jul 2, 2019 · 1 comment

Comments

@NikxDa
Copy link

NikxDa commented Jul 2, 2019

Hey there,

I would like to suggest a feature that allows the slider to have multiple selected cells. There have been several issues like this discussed, but most of them focused on how to determine a slider boundary, not so much the issue of multiple selected elements.

Here's the issue broken down:

  • A slider with contain: true will still be able to change slides without actually moving (as referenced in Disable prev/next buttons for contain #289)
  • A slider with groupCells will not have this issue, but will behave differently when sliding (not sliding one at a time, but per group).

I wonder if it is possible to achieve the following scenario (where X is a slide that is selected, x (lowercase) is a normal slide, and the viewport is determined by []:

x x [ X X X ] x x -> next -> x x x [ X X X ] x

I would envision a property called selectionSize that starts out with the first selectionSize items being selected, and then shifts them one at a time when moving in either direction. This would be really useful for cases where slides need to move one at a time, with multiple slides being in viewport, and the inactive slides having certain styles (like opacity) set.

@NikxDa NikxDa changed the title Correctly handle multiple selected cells Ability to handle multiple selected cells Jul 2, 2019
@desandro
Copy link
Member

desandro commented Jul 7, 2019

Thanks for this feature request. Between contain and groupCells I feel these features cover enough accommodate most use cases. Adding a third behavior may help, but would make only make things more complicated. For example, how would selectionSize work with groupCell. I appreciate the idea but I'll have to pass on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants