-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to import zdog with es6 syntax #10
Comments
This is indeed a bug. I totally forgot to attach the classes to the |
I know what it’s like trying to do projects in between being a new parent, I think it’s amazing you managed to do all this. A few bugs are bound to slip through! Really awesome project. Would you like me to have a go at a PR? |
I'll take care of this in the next release. Thanks for the offer and the kind words 🐶 |
+ pass in window for server-side env
Just installed your patch, and I'm seeing an error after calling
I was able to fix by forcing the window variable after import
|
👕 add .jshintrc js/, demos/, tasks 📦 npm ignore dotfiles
@desandro Are there plans for full React compatibility? Right now an |
It’s maybe not your ideal solution but I managed to implement it in a react app by using refs in react. You will need to use effect as well as ref is undefined when the page loads |
I'm trying to import
Not sure what's going on 🤔 The same code runs fine with: <script src="https://unpkg.com/[email protected]/dist/zdog.dist.min.js"></script> |
v1.0.2 has been released with fixes for these bug. Please update! Closing as fixed. |
I tried out the 1.0.2 release today, and it looks like although the es6 imports are working now, I ran into the same dragger bug @marcelinollano mentioned.
|
@mkaemmerer I've opened #49 to track this separate issue. |
When es6 import syntax none of the modules are exported or available on the Zdog class
Test case: https://codesandbox.io/embed/hungry-darwin-59jh7
The text was updated successfully, but these errors were encountered: