Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line across inside cylinder when fill is false #106

Open
Coehill opened this issue Jan 21, 2021 · 2 comments
Open

Line across inside cylinder when fill is false #106

Coehill opened this issue Jan 21, 2021 · 2 comments

Comments

@Coehill
Copy link

Coehill commented Jan 21, 2021

Test case: https://codepen.io/coehill/pen/OJRGavP

When a cylinder is created that has fill: false, there is a line across the centre. It can be removed by setting the color to be the same as the background, however this turns the model into an ellipse.

@desandro
Copy link
Member

Thanks for reporting this issue. I imagine you're looking for a hollow cylinder, which the Cylinder shape does not support 😢. Zdog's Cylinder works as a hack by rendering a the curved surface as a rectangle. Setting fill breaks this illusion.

If you do need to render a hollow cylinder, the closest solution would be to render multiple Rects rotated around a center point.

@Coehill
Copy link
Author

Coehill commented Jan 24, 2021

I appreciate the suggestion @desandro!. I decided to render multiple Ellipses stacked on the z-axis which worked for my purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants