Skip to content

Commit 5a8a403

Browse files
malfetpytorchmergebot
authored andcommittedMar 14, 2023
[BE] Add regression test for aten shared build (pytorch#96697)
To expose errors similar to pytorch#94401 (comment) in OSS CI Building `aten_cpu` as a shared library with `-Wl,--no-undefined` simulates behavior of Android NDK toolchain. Test plan: It should fail, see https://github.com/pytorch/pytorch/actions/runs/4410571970/jobs/7728232916#step:14:1386 Pull Request resolved: pytorch#96697 Approved by: https://github.com/kit1980
1 parent a22b92d commit 5a8a403

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed
 

‎.buckconfig.oss

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
[cxx]
1616
cxxflags = -std=c++17
17+
ldflags = -Wl,--no-undefined
1718
should_remap_host_platform = true
1819
cpp = /usr/bin/clang
1920
cc = /usr/bin/clang

‎.github/workflows/_buck-build-test.yml

+5-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
timeout_minutes: 10
7474
max_attempts: 5
7575
command: |
76-
sh scripts/buck_setup.sh
76+
bash scripts/buck_setup.sh
7777
7878
- name: Build tools
7979
run: |
@@ -122,3 +122,7 @@ jobs:
122122
- name: Build everything
123123
run: |
124124
buck build //... --keep-going
125+
126+
- name: Build aten_cpu@shared
127+
run: |
128+
buck build :aten_cpu#linux-x86_64,shared

0 commit comments

Comments
 (0)
Please sign in to comment.