Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory data_revision on all obs-readers, disable last-file check in caching #1244

Open
1 of 2 tasks
heikoklein opened this issue Jul 5, 2024 · 3 comments
Open
1 of 2 tasks
Labels
enhancement ✨ New feature or request
Milestone

Comments

@heikoklein
Copy link
Member

heikoklein commented Jul 5, 2024

Is your feature request related to a problem? Please describe.
Caching of ungridded data relies on both data_revision and newest_file_in_read_dir, see #1242 . The newest_file_in_read_dir test is error prone since a touch or another minor filesystem operation will invalidate the cache, in addition it can be very slow, e.g. for the EEA-reader. If observation-readers deliver their own mandatory data_revision, the too general test can be removed.

Describe the solution you would like to see

@heikoklein heikoklein added the enhancement ✨ New feature or request label Jul 5, 2024
@heikoklein heikoklein added this to the m2024-09 milestone Jul 5, 2024
@heikoklein heikoklein modified the milestones: m2024-09, m2024-10 Sep 11, 2024
@lewisblake lewisblake modified the milestones: m2024-10, m2024-11 Oct 1, 2024
@lewisblake lewisblake self-assigned this Oct 21, 2024
@Ovewh
Copy link
Collaborator

Ovewh commented Oct 28, 2024

What about updating the cache between versions of pyaerocom? From a user standpoint there the should be warning if the cached ungridded data where generated with a different version of pyaerocom. I encountered issues due to changes in pyaerocom made my cached file incompatible and causing some not obvious errors...

@heikoklein
Copy link
Member Author

@Ovewh When did you encounter such problems? The cache is independent of the pyaerocom-version, and pyaerocom-versions change often. The cache is dependent on the ungriddeddata-version, which is checked. The cache might also be dependent on external libraries, but those are partly unchecked.

@Ovewh
Copy link
Collaborator

Ovewh commented Oct 29, 2024

I couldn't rerun my analysis due to some station names including / that resulted in an error that I did get before. Due Pyaerocom reading the cache, (which i did not realize at first) the error persisted even if I changed the problematic station name by replacing / with _ . I thought that this error was due to some additional checks introduced by updates to pyaerocom?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants