Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up model_kwargs #1383

Open
lewisblake opened this issue Oct 21, 2024 · 0 comments
Open

Clean up model_kwargs #1383

lewisblake opened this issue Oct 21, 2024 · 0 comments

Comments

@lewisblake
Copy link
Member

Is your feature request related to a problem? Please describe.
model_kwargs appears in three different places in a config and it's very confusing what the differences are. It appears in colocation_opts, in ModelEntry instances, and in ModelEntry.kwargs.

Describe the solution you would like to see

model_kwargs should only exist at in one place and all parts of the code which need it should reference that one place.

  • Would you be able to work on this solution yourself? Yes, but I would like to involve @dulte on these disucssions as well. We've started working a bit on this.
  • How can the Pyaerocom development team assist you? NA

Additional context
#1381
#1184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant