Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregating several obs networks using aeroval fails when the networks don't provide the same unit natively #1499

Open
jgriesfeller opened this issue Jan 31, 2025 · 1 comment
Labels
bug 🐛 Something isn't working CAMS2_82 Issues related to the CAMS2_82 contract
Milestone

Comments

@jgriesfeller
Copy link
Member

jgriesfeller commented Jan 31, 2025

Describe the bug
In CAMS2-82 we put together several obs network to one so that they can be evaluated together. Evaluating e.g. ozone where SINCA provides ozone in ug/m^3 doesn't include SINCA in All obs although it's in the config
All obs (missing e.g SINCA):
Image

But the actual analysis is done despite SINCA using the wrong unit (ug/m^3)
Image

To Reproduce
Steps to reproduce the behavior:
rerun aeroval

Expected behavior
the first image should also contain the SINCA data

Additional context
concerns the variables vmro3 and vmrno2

@jgriesfeller jgriesfeller added bug 🐛 Something isn't working CAMS2_82 Issues related to the CAMS2_82 contract labels Jan 31, 2025
@jgriesfeller jgriesfeller added this to the m2025-03 milestone Jan 31, 2025
@lewisblake
Copy link
Member

Short fix it to preprocess data to be in correct units

@thorbjoernl thorbjoernl modified the milestones: m2025-03, m2025-04 Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working CAMS2_82 Issues related to the CAMS2_82 contract
Projects
None yet
Development

No branches or pull requests

3 participants