Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS decompression loops #443

Closed
gaya-cohen opened this issue May 20, 2021 · 1 comment
Closed

DNS decompression loops #443

gaya-cohen opened this issue May 20, 2021 · 1 comment

Comments

@gaya-cohen
Copy link
Contributor

gaya-cohen commented May 20, 2021

Parsing malformed DNS packets places the library in a while-true state.
Attached is a capture file.

loop_each_other_responses.cap.gz
image

Notice the function DNS::compose_name in dns.cpp only contains a check for the offset not being too low or high, but not a check for whether the offset loops.

image
#444

@mfontanini
Copy link
Owner

Closing as #444 fixed it. Thanks for raising the issue and PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants