Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup github actions #61

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Conversation

youknowone
Copy link
Contributor

Please feel free to close it if you didn't set it up by policy

@youknowone
Copy link
Contributor Author

4 tests are looking fail:

---- num::arithmetic::root::ceiling_root_properties stdout ----
thread 'num::arithmetic::root::ceiling_root_properties' panicked at /rustc/e71f9a9a98b0faf423844bf0ba7438f29dc27d58/library/core/src/num/mod.rs:1223:5:
attempt to multiply with overflow

---- num::arithmetic::root::checked_root_properties stdout ----
thread 'num::arithmetic::root::checked_root_properties' panicked at /rustc/e71f9a9a98b0faf423844bf0ba7438f29dc27d58/library/core/src/num/mod.rs:1223:5:
attempt to multiply with overflow

---- num::arithmetic::root::floor_root_properties stdout ----
thread 'num::arithmetic::root::floor_root_properties' panicked at /rustc/e71f9a9a98b0faf423844bf0ba7438f29dc27d58/library/core/src/num/mod.rs:1223:5:
attempt to multiply with overflow

---- num::arithmetic::root::root_rem_properties stdout ----
thread 'num::arithmetic::root::root_rem_properties' panicked at /rustc/e71f9a9a98b0faf423844bf0ba7438f29dc27d58/library/core/src/num/mod.rs:1223:5:
attempt to multiply with overflow

@mhogrefe
Copy link
Owner

Thanks for setting up these checks, @youknowone. I usually only run tests in release mode, since all the tests take about 2 hours in release mode and would take even longer in debug mode. That's why I missed these overflow errors, which only show up in debug mode. I'll push out a fix soon.

@mhogrefe mhogrefe merged commit 0af9120 into mhogrefe:master Feb 16, 2025
1 check failed
@mhogrefe
Copy link
Owner

Although there are benefits to running tests in debug mode (like finding those bugs), it just takes too long. It looks like the latest action was automatically cancelled after running for 6 hours. I've changed the tests to run in release mode.

@youknowone youknowone deleted the github-actions branch February 17, 2025 02:27
@youknowone
Copy link
Contributor Author

Separating test groups to make simple and fast tests run on debug mode and others on release to take advantage of both overflow checking and optimized running can be another option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants