Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match MMDevice enums for FocusDirection with the ±1 used in MMCore API #558

Open
marktsuchida opened this issue Feb 5, 2025 · 1 comment

Comments

@marktsuchida
Copy link
Member

marktsuchida commented Feb 5, 2025

If nothing else, this should avoid unnecessary confusion.

This will (theoretically) break the device interface version, but we have a few of those changes coming up so now is a good time.

("theoretically" because none of our in-tree device adapters actually use these constants.)

Cc: @tlambert03

@tlambert03
Copy link
Contributor

sounds good if possible.

relevant issues:
pymmcore-plus/pymmcore-plus#427
pymmcore-plus/pymmcore-plus#428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants