Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DahengGalaxy doesn't build with VS2022 (v143) toolset #578

Open
marktsuchida opened this issue Feb 26, 2025 · 2 comments
Open

DahengGalaxy doesn't build with VS2022 (v143) toolset #578

marktsuchida opened this issue Feb 26, 2025 · 2 comments

Comments

@marktsuchida
Copy link
Member

marktsuchida commented Feb 26, 2025

When the platform toolset is upgraded to v143 (testing for a future upgrade to VS2022), we get the following error.
Presumably the volatile is a mistake, but it's part of the vendor SDK, so ideally we'd get an updated version from them.

3rdpartypublic\DahengGalaxy\inc\GXSmartPtr.h(38,2): error C7731: 'volatile' is not allowed on a constructor declaration
@nicost
Copy link
Member

nicost commented Feb 27, 2025

The SDK we have in 3rdpartypublic is the latest available from their website.

There also is an SDK in C. Preferably we would use that (as it would also work on linux, where they apparently do not have a C++ version), but that means re-writing the device adapter code.

@marktsuchida
Copy link
Member Author

For the purpose of building with VS2022 tools, we could patch the SDK header (just remove the word volatile; it is not doing anything anyway). I just meant we should let them know of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants