Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeadowlarkLC doesn't build with VS2022 (v143) toolset #579

Open
marktsuchida opened this issue Feb 26, 2025 · 1 comment
Open

MeadowlarkLC doesn't build with VS2022 (v143) toolset #579

marktsuchida opened this issue Feb 26, 2025 · 1 comment

Comments

@marktsuchida
Copy link
Member

When the platform toolset is upgraded to v143 (testing for a future upgrade to VS2022), we get the following error.

DeviceAdapters\MeadowlarkLC\MeadowlarkLC.cpp(219,19): error C7664: '>=': ordered comparison of pointer and integer zero ('HANDLE' and 'int')

This is at

.

HANDLE is a typedef to void *, so it's not immediately clear how to fix this. Possibly cast the left hand side to signed intptr_t, but best to check the programming manual on the return value of USBDRVD_OpenDevice().

@marktsuchida
Copy link
Member Author

The original expression is always true (because MSVC takes dev_Handle to be unsigned), and I'm 90% sure it's supposed to be if (dev_Handle != 0) (based on disassembly of USBDRVD_OpenDevice()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant