Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules are bad and defaulting to https #39

Open
iclaxton opened this issue Jan 5, 2024 · 2 comments
Open

Submodules are bad and defaulting to https #39

iclaxton opened this issue Jan 5, 2024 · 2 comments

Comments

@iclaxton
Copy link
Collaborator

iclaxton commented Jan 5, 2024

Thanks for the invite to join this repo!

I use SSH but when I clone this repo the submodules are listed as https so I get a request for a username and password. For some reason (I assume 2FA), I'm unable to sign-in so unable to update the submodule.

Maybe I'm doing something wrong but I've never been a fan of submodules and while I can see the use-case here, I think this could lead to more issues and reduced usage of this repro.

Ian

@iclaxton
Copy link
Collaborator Author

iclaxton commented Jan 5, 2024

I resolved the issue by editing the .git/config file direct but maybe you should include some information about submodules in the readme. This is the first time I have used them in 25 years of professional development as I prefer the package approach. I'm sure with pip you can reference a git repo and update when needed.

@jinlin-bayarea
Copy link
Collaborator

I have updated the file .git/config as follows.
[submodule "7B_FT_float32"]
active = true
url = [email protected]:microsoft/Llama-2-Onnx-7-FT-32.git

git submodule update
Cloning into '/Users/xxx/xxx/Llama-2-Onnx/7B_FT_float32'...
Submodule path '7B_FT_float32': checked out 'b0c079914d04b5e18e890b0db5cf29ede258f613'

I don't see the expected 10GB onnx file. Do I miss something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants