Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Visual diffs succeed if new component reference images weren't committed #356

Open
swese44 opened this issue May 29, 2018 · 0 comments
Open

Comments

@swese44
Copy link
Contributor

swese44 commented May 29, 2018

Basically builds will pass if a new component is added without generating and committing the visual diffs. example:
#321

this is because new images are auto-generated if they're missing, and if somebody doesn't manually add them then the CI run will auto-generate them and succeed.

i think we should update https://github.com/unindented/react-styleguidist-visual to fail if it generates new images to force us to manually create those images

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant